Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vasilis/casestudy #441

Merged
merged 62 commits into from
May 3, 2021
Merged

Vasilis/casestudy #441

merged 62 commits into from
May 3, 2021

Conversation

vsyrgkanis
Copy link
Collaborator

Fixed small mistakes in multi-investment attribution case study (fixes #437).
Changed how aggregation happens in policy ensembles to follow a "voting" paradigm, where the treatment with the most votes is chosen.
Added a predict_proba method to policy learners.

@vsyrgkanis vsyrgkanis added bug Something isn't working enhancement New feature or request labels Mar 25, 2021
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few minor suggestions, but this looks good to me.

econml/tests/test_policy_forest.py Outdated Show resolved Hide resolved
econml/policy/_forest/_tree.py Show resolved Hide resolved
econml/policy/_forest/_forest.py Outdated Show resolved Hide resolved
econml/policy/_forest/_forest.py Outdated Show resolved Hide resolved
econml/policy/_drlearner.py Outdated Show resolved Hide resolved
vsyrgkanis and others added 9 commits April 13, 2021 19:13
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
@vsyrgkanis vsyrgkanis merged commit 5bf448a into master May 3, 2021
@vsyrgkanis vsyrgkanis deleted the vasilis/casestudy branch May 3, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in customer scenario notebook
3 participants