Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Conditional discrepancy (k-sample) Bregman test #82

Merged
merged 21 commits into from
Jan 11, 2023
Merged

[ENH] Conditional discrepancy (k-sample) Bregman test #82

merged 21 commits into from
Jan 11, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Jan 8, 2023 •
edited
Loading

Closes: #57 and is the next step for #56. Builds upon the work in #81.

Must merge #81 first before approving and merging this.

Changes proposed in this pull request:

  • Implements the conditional Bregman test for testing for conditional discrepancy

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@adam2392
KCD test
8a7e917 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Add test
a48dfe7 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
REfactor utils
0d94a39 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Ready for review
b0c765b 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Fix' -s
e2fa245 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Fix pr number
506a931 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Fix docs
23a579a 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Add additional tests
3063e75 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Initial commit
2874bb3 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Add pr
9a37306 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Fixed
257a7c2 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 requested review from robertness and removed request for robertness January 8, 2023 20:04
@adam2392
Fixing the kernel test
2f38090 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Add bregman cd test
c102b9f 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Fixing bug
616c682 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 mentioned this pull request Jan 9, 2023
Closed
5 tasks
@adam2392
Merge branch 'main' into kcd
eb7770f
@adam2392
Merge branch 'main' into bregman
227f517
@adam2392
Fix style
8f991c4 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Merge branch 'kcd' into bregman
84de0f5
@adam2392
Fix api docs
3f72ee2 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Add ref
21a5d62 
Signed-off-by: Adam Li <adam2392@gmail.com>
robertness
robertness reviewed Jan 11, 2023
View reviewed changes
dodiscover/cd/base.py Outdated Show resolved Hide resolved
robertness
robertness approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@robertness robertness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adam2392 adam2392 enabled auto-merge (squash) January 11, 2023 01:51
@adam2392
Merge branch 'main' into bregman
58cc1c4 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 mentioned this pull request Jan 11, 2023
Closed
@adam2392 adam2392 merged commit e305897 into py-why:main Jan 11, 2023
@adam2392 adam2392 deleted the bregman branch January 11, 2023 02:21
robertness pushed a commit that referenced this pull request Jan 13, 2023
@adam2392 @robertness
[ENH] Conditional discrepancy (k-sample) Bregman test (#82)
28e0aa6 
* KCD test for testing conditional discrepancy
* Add bregman cd test for testing conditional discrepancy

Signed-off-by: Adam Li <adam2392@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertness robertness robertness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adam2392 @robertness