-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add conditional mutual information test #83
Conversation
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 79.70% 83.35% +3.64%
==========================================
Files 24 24
Lines 1493 1562 +69
Branches 246 259 +13
==========================================
+ Hits 1190 1302 +112
+ Misses 215 168 -47
- Partials 88 92 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Perhaps we should edit the design goals in the README to mention a suite of conditional independence tests that are far more robust than in most libraries.
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@robertness can you approve this again, so this can be merged? Take a look at the new unit test file and this now works properly with and without a conditioning set. There was a bug before that broke the test when it was just non-conditional independence testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Adding cmi test with KNN * Fix unit test Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li adam2392@gmail.com
First part of #17
Changes proposed in this pull request:
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting