Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional api/causal estimators #746

Merged
merged 56 commits into from Dec 3, 2022
Merged

Functional api/causal estimators #746

merged 56 commits into from Dec 3, 2022

Commits on Nov 28, 2022

  1. Initial refactor 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    487aa58 View commit details
    Browse the repository at this point in the history

  2. fix placebo treatment refuter randint call (#702) 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>

Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    8a4a108 View commit details
    Browse the repository at this point in the history

  3. Adding ProductRegressor to gcm auto assignment 

    This model simply takes the product of the inputs.

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6301b63 View commit details
    Browse the repository at this point in the history

  4. Make conditional independence test based on regression less flaky 

    Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    31ab411 View commit details
    Browse the repository at this point in the history

  5. Add workflow to mark and close stale issues 

    Signed-off-by: Peter Goetz <pego@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @petergtz @andresmor-ms
    petergtz authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    94c554d View commit details
    Browse the repository at this point in the history

  6. Mark econml, pydot, and pygraphviz as extras (#701) 

    * mark econml, pydot, and pygraphviz as extras

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* restore dep order

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @darthtrevino @andresmor-ms
    darthtrevino authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d457ad8 View commit details
    Browse the repository at this point in the history

  7. Change mechanics of Docker image build and usage 

    - Introduce a GH Action to build Docker image for docs generation every time the Dockerfile is changed
- Trigger docs generation when a new Docker image was built
- Minor fix in Dockerfile to avoid outdated apt database

Signed-off-by: Peter Goetz <pego@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @petergtz @andresmor-ms
    petergtz authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    9eb209f View commit details
    Browse the repository at this point in the history

  8. Fix GH Actions workflow docs trigger 

    This needs to point to the correct title.

Signed-off-by: Peter Goetz <pego@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @petergtz @andresmor-ms
    petergtz authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    610d2f5 View commit details
    Browse the repository at this point in the history

  9. Add an option for auto assignment in distribution change attribution 

    Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    cc45a33 View commit details
    Browse the repository at this point in the history

  10. Binary bool features now remain binary in one hot encoding for ANMs i… 

    …n gcm

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    7aa6d1f View commit details
    Browse the repository at this point in the history

  11. Import dowhy.causal_estimators.econml locally (#713) 

    This imports it within the function where it's used. It removes the hard dependency on EconML and only requires it when using sensitivity_non_parametric_partial_r2.

Signed-off-by: Peter Goetz <pego@amazon.com>

Signed-off-by: Peter Goetz <pego@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @petergtz @andresmor-ms
    petergtz authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    26a3c08 View commit details
    Browse the repository at this point in the history

  12. Adding causal-learn as (required) dependency 

    The gcm module will heavily rely on the independence tests in the causal-learn package, i.e., it cannot be optional.

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    de0936a View commit details
    Browse the repository at this point in the history

  13. Add econml, pydot extras to Documentation Build (#714) 

    * add econml, pydot extras to docs build

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* add econml, pydot extras to other build tasks

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* update nightly install

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @darthtrevino @andresmor-ms
    darthtrevino authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a47c85a View commit details
    Browse the repository at this point in the history

  14. Replace HSCI and KCI with causal-learn package functions 

    The causal-learn package provides more sophisticated implementations of the kernel independence tests. Instead of reimplementing it, we utilize the existing functions from causal-learn instead.

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    9ef3116 View commit details
    Browse the repository at this point in the history

  15. Add pytest markers for "focused" and "notebook" (#716) 

    add pytest markers for notebook, focused to remove runtime warnings

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @darthtrevino @andresmor-ms
    darthtrevino authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    9379510 View commit details
    Browse the repository at this point in the history

  16. Make a gcm unit test for drawing from an interventional distribution … 

    …less flaky (#715)

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    c1dde07 View commit details
    Browse the repository at this point in the history

  17. Fix docs-on-demand Issues (#718) 

    * fix issues with docs-on-demand GH Actions script

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* update image name

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* restore jupyter notebook from main

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* remove accidentally added file

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @darthtrevino @andresmor-ms
    darthtrevino authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    54fac0b View commit details
    Browse the repository at this point in the history

  18. Fix avoid retrain estimator on causal_model API 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    23f07e4 View commit details
    Browse the repository at this point in the history

  19. Add independence tests as parameter to distribution change 

    This removes the option to change the mechanism change test directly. As it turned out, changing the independence test is the more common case.

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1736e52 View commit details
    Browse the repository at this point in the history

  20. Make unit test on intervention less strict 

    To avoid flaky tests.

Signed-off-by: Peter Goetz <pego@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @petergtz @andresmor-ms
    petergtz authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6f8f159 View commit details
    Browse the repository at this point in the history

  21. Fix issue with identifying boolean values of dataframes in is_categor… 

    …ical

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    86d6159 View commit details
    Browse the repository at this point in the history

  22. Restore some key tests into the regular CI pipeline (#725) 

    * restore some key notebook tests

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* remove advanced marks from unit tests

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* remove advanced mark from test_validation.py

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* apply formatting

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* update test durations, restore some test notebooks

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* bump the test splits

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

* restore main notebook tests, take a more piecemeal approach

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @darthtrevino @andresmor-ms
    darthtrevino authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0607495 View commit details
    Browse the repository at this point in the history

  23. Re-introduce include_simulated_confounder as method 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    aa42bc7 View commit details
    Browse the repository at this point in the history

  24. Add constants name 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    e37f5ec View commit details
    Browse the repository at this point in the history

  25. Use a different github action for notifying discord (#731) 

    use a different github action for notifying discord

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @darthtrevino @andresmor-ms
    darthtrevino authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ad57be8 View commit details
    Browse the repository at this point in the history

  26. Set seed on data generation for deterministic test 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    8939bad View commit details
    Browse the repository at this point in the history

  27. Uncomment notebook examples for coverage 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d26b618 View commit details
    Browse the repository at this point in the history

  28. Check random_state type on placebo_treatment_refuter Fix #719 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    f949c4f View commit details
    Browse the repository at this point in the history

  29. introduce fit() method for causal estimators 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1bb4c03 View commit details
    Browse the repository at this point in the history

  30. Fix refuters after estimator refactor 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6830d08 View commit details
    Browse the repository at this point in the history

  31. Fix refutation issues 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    bfaa200 View commit details
    Browse the repository at this point in the history

  32. Fix estimator issues 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4d6d58e View commit details
    Browse the repository at this point in the history

  33. Restore Notebook Tests in Regular CI (#728) 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @darthtrevino @andresmor-ms
    darthtrevino authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    51e030b View commit details
    Browse the repository at this point in the history

  34. Upgrade xgboost (#739) 

    upgrade xgboost

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>

Signed-off-by: Chris Trevino <darthtrevino@gmail.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @darthtrevino @andresmor-ms
    darthtrevino authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d2da2f6 View commit details
    Browse the repository at this point in the history

  35. Remove bibtex from GCM introduction 

    This is covered in docs/source/cite.rst.

Signed-off-by: Peter Goetz <pego@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @petergtz @andresmor-ms
    petergtz authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    117cbf8 View commit details
    Browse the repository at this point in the history

  36. Add 'Typical usage' section in GCM introduction 

    Signed-off-by: Peter Goetz <pego@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @petergtz @andresmor-ms
    petergtz authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    69e4dba View commit details
    Browse the repository at this point in the history

  37. Fix issue with categorical inputs to gcm ProductRegressor 

    Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    8191e19 View commit details
    Browse the repository at this point in the history

  38. Use concat instead of append for pandas in distribution change 

    This avoids a future deprecation warning.

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    af49f21 View commit details
    Browse the repository at this point in the history

  39. Remove unnecessary double underscores in gcm module 

    Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6a49245 View commit details
    Browse the repository at this point in the history

  40. Rename gcm bootstrap training to fit_and_compute 

    Related to issue #689

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @bloebp @andresmor-ms
    bloebp authored and andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2128f73 View commit details
    Browse the repository at this point in the history

  41. Clean output of notebook 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d500faf View commit details
    Browse the repository at this point in the history

  42. format + small fix on tests 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    5a9953e View commit details
    Browse the repository at this point in the history

  43. Add docs 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    98d23a5 View commit details
    Browse the repository at this point in the history

  44. Add docs to fit() 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    9095c39 View commit details
    Browse the repository at this point in the history

  45. Add types to constructors 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    f1a589e View commit details
    Browse the repository at this point in the history

  46. Apply format 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d1ea8de View commit details
    Browse the repository at this point in the history

  47. Use protocol for econml and causalml, PR comments 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    3ec9d3c View commit details
    Browse the repository at this point in the history

  48. update docs for estimator classes 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d1dc97d View commit details
    Browse the repository at this point in the history

  49. Add optional data param for estimate_effect 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    eb7a763 View commit details
    Browse the repository at this point in the history

  50. Update docs 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    c419f9d View commit details
    Browse the repository at this point in the history

  51. Merge branch 'main' into functional_api/causal_estimators 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d7b29cf View commit details
    Browse the repository at this point in the history

  52. Fix merge 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    605d176 View commit details
    Browse the repository at this point in the history

  53. Format code 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    45772f1 View commit details
    Browse the repository at this point in the history

  54. Address PR comments 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    972b071 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Add docs + fix placebo_refuter 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0b52e75 View commit details
    Browse the repository at this point in the history

  2. Update docs 

    Signed-off-by: Andres Morales <andresmor@microsoft.com>
    @andresmor-ms
    andresmor-ms committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    6596f39 View commit details
    Browse the repository at this point in the history