Add method and example to falsify a user-given DAG using a permutation-based test #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @eeulig, Thank you for this PR! I haven't reviewed it, but do notice that the DCO (developer certificate of origin) test is failing. If you click on the details link here, there are instructions on how to resolve this. Could you take a look at that, and let us know if the instructions are unclear. Thank you again! |
bloebp
reviewed
Apr 28, 2023
…n-based test Signed-off-by: eeulig <contact@eeulig.com>
Signed-off-by: eeulig <contact@eeulig.com>
eeulig
force-pushed
the
feat/falsify_dags
branch
from
7ffb8e4
to
c99833b
Compare
Signed-off-by: eeulig <contact@eeulig.com>
Signed-off-by: eeulig <contact@eeulig.com>
bloebp
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcm.falsify.evaluate_graphtakes as input a user-given DAG and some observational data and returns a measure of how much better the given DAG is than a random node permutations in terms of the CIs it entails. The function can also report suggestions to the user via the flagsuggestionsand visualize the result via the flagplot.docs/source/example_notebooks/gcm_falsify_dag.ipynb.tests/gcm/test_falsify.py.