Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Function for converting PAG to MAG #86

Closed
wants to merge 1 commit into from

Conversation

aryan26roy
Copy link
Collaborator

Closes #85

Changes proposed in this pull request:

  • Adds a function for converting PAGs to MAGs.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Aryan Roy <aryanroy@Aryans-MacBook-Air.local>
@adam2392
Copy link
Collaborator

I think you want a function that goes MAG to PAG?

A PAG has many MAGs possibly associated with it.

@aryan26roy
Copy link
Collaborator Author

Ah ok. This for after the MAG has been validated in #73.

@adam2392
Copy link
Collaborator

Can you describe the algorithm in the PR description?

@aryan26roy
Copy link
Collaborator Author

@adam2392 moving the discussion to #87

@aryan26roy aryan26roy closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert MAG to PAG
2 participants