Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dest_dir option in py2exe.freeze is broken #160

Closed
matiusz opened this issue Nov 16, 2022 · 1 comment
Closed

dest_dir option in py2exe.freeze is broken #160

matiusz opened this issue Nov 16, 2022 · 1 comment
Labels
bug Something isn't working documentation

Comments

@matiusz
Copy link

matiusz commented Nov 16, 2022

According to py2exe.freeze documentation, in order to set destination directory one needs to specify "dest_dir" option. After this option doing absolutely nothing, I've checked the source code and found the following line:
destdir = options.get("dist_dir", "dist"),, and lo and behold, specifying "dist_dir" works. So obviously there is a mismatch between the option in the code and in the documentation.
My suggestion: obviously correct one of the parts to have the option be named consistently, but also warn the user about unexpected options parsed.

@albertosottile
Copy link
Member

Thanks for reporting this. I apologize, I thought I had tested this with https://github.com/Syncplay/syncplay/blob/fa06378b6dbdef8ae83071fdc0853f897c735ddc/buildPy2exe.py#L696 but indeed also there the option is named dist_dir.

After searching in the code base, it seems indeed the correct option name is dist_dir and so the typo is in the documentation. I will fix the documentation ASAP.

@albertosottile albertosottile added bug Something isn't working documentation labels Nov 16, 2022
albertosottile added a commit that referenced this issue Nov 16, 2022
albertosottile added a commit that referenced this issue Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation
Projects
None yet
Development

No branches or pull requests

2 participants