Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AnnAssign for nim and kotlin #71

Merged
merged 5 commits into from Apr 16, 2021
Merged

Fix AnnAssign for nim and kotlin #71

merged 5 commits into from Apr 16, 2021

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Apr 16, 2021

No description provided.

@adsharma
Copy link
Collaborator

Thanks for fixing. The code looks fine. Perhaps run black/nimpretty on the generated code.

Both of them prefer:

a: int = 10

vs

a : int = 10

@jayvdb
Copy link
Member Author

jayvdb commented Apr 16, 2021 •
edited

will do, and will push after rebasing on top of #67 once it is merged

@jayvdb jayvdb mentioned this pull request Apr 16, 2021
Closed
@adsharma adsharma merged commit 41c2cac into py2many:main Apr 16, 2021
@jayvdb jayvdb deleted the ann-assign branch August 13, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jayvdb @adsharma