Issue 374 Add type hint #510
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Mar 9, 2023
mucharafal
force-pushed
the
issue-374-integer-type-hint
branch
from
5e91317
to
0471bbb
Compare
|
Sorry for the delay. Now the tests are fixed per #519. Would you mind rebasing this one please? |
mucharafal
force-pushed
the
issue-374-integer-type-hint
branch
from
0471bbb
to
9bf48a6
Compare
|
Done. Could you run pipeline? |
mucharafal
force-pushed
the
issue-374-integer-type-hint
branch
2 times, most recently
from
eb083b4
to
0e2baca
Compare
mucharafal
force-pushed
the
issue-374-integer-type-hint
branch
from
6051868
to
a642fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on #500, if Bodo-inc#1 is merged, then this may be closed.