Disable Nagle's algorithm on loopback sockets. #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. Now the tests are fixed per #519. Would you mind rebasing this one please? |
|
Hello, I merged the main branch. Is it ok now? |
HyukjinKwon
reviewed
Mar 24, 2024
| @@ -74,6 +74,10 @@ public ClientServerConnection(Gateway gateway, Socket socket, List<Class<? exten | |||
| throws IOException { | |||
| super(); | |||
| this.socket = socket; | |||
|
|
|||
| // disable Nagle's algorithm on loopback connection to avoid performance issues due to write,write,read situations | |||
| if (socket.getLocalAddress().isLoopbackAddress()) socket.setTcpNoDelay(true); | |||
There was a problem hiding this comment.
Do we have a rough evidence for this performance improvement? e.g., benchmark.
There was a problem hiding this comment.
And what's the impact of disabling this?
There was a problem hiding this comment.
See #516 for background and a measurement for a slow case. For the loopback interface I would assume, there are no negative performance impacts for disabling Nagle. I would have assumed it to be the default on loopback, but that seems not to be always the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue 516.