Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove g from py5 #322

Closed
3 tasks done
hx2A opened this issue Jul 21, 2023 · 4 comments · Fixed by #362
Closed
3 tasks done

Remove g from py5 #322

hx2A opened this issue Jul 21, 2023 · 4 comments · Fixed by #362

Comments

@hx2A
Copy link
Collaborator

hx2A commented Jul 21, 2023

Currently py5.g is deprecated. This issue is a reminder to remove it completely from py5 in a future build.

  • remove g
  • confirm that it is no longer a reserved name for a variable or a function
  • update the reference documentation. Should it be removed completely, or add a note saying "as of version X, this has been removed from py5?"

See #317 for prior discussion.

@villares
Copy link
Contributor

villares commented Jul 26, 2023

I like the idea of leaving some note about the removal!

@hx2A
Copy link
Collaborator Author

hx2A commented Jul 27, 2023

I like the idea of leaving some note about the removal!

OK, that's what I will do.

@villares
Copy link
Contributor

villares commented Aug 2, 2023

This page's example will be affected by the g removal: https://py5coding.org/reference/py5graphics_next_page.html

@hx2A
Copy link
Collaborator Author

hx2A commented Aug 2, 2023

This page's example will be affected by the g removal: https://py5coding.org/reference/py5graphics_next_page.html

Good catch! I just fixed that. There shouldn't be any deprecated code in the documentation.

There are no other similar examples and no links to the .g reference doc pages.

@hx2A hx2A closed this as completed in #362 Oct 6, 2023
hx2A added a commit that referenced this issue Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants