Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map out structure of domzgr.F90 #2

Closed
jdha opened this issue May 12, 2021 · 6 comments
Closed

Map out structure of domzgr.F90 #2

jdha opened this issue May 12, 2021 · 6 comments
Assignees
Labels
task do something!

Comments

@jdha
Copy link
Contributor

jdha commented May 12, 2021

Produce skeleton of domzgr.F90 routines to hang the python package on.

@jdha jdha added the task do something! label May 12, 2021
@jdha jdha added this to In progress in domzgr.F90 -> pyDOMCFG May 12, 2021
@oceandie
Copy link
Contributor

oceandie commented May 13, 2021

HI guys,

I generated the NEMO4.0.4-DOMAINcfg tool call tree documentation using doxygen ( https://www.doxygen.nl/index.html ) with graphviz ( http://www.graphviz.org ).
The output of these software is a bunch of html files that would be nice to include in our pyNEMO documentation.

As far I understood (from @malmans2 ’s notes), our documentation will be automatically generated and managed by Sphynx.
How would you recommend I include my doxygen html documentation in our project?

@oceandie
Copy link
Contributor

oceandie commented May 13, 2021

As @malmans2 noted, we're not going to upload NEMO code on GitHub - so doc for FORTRAN DOMAINcfg needs to be generated only once. He suggests to put it into pyDOMCFG/docs/_static (maskes sense to me as well) and then just add a reference to it (I am not sure I understand this correctly - you mean in the index?).

@malmans2 also asked about graphviz, since there is an extension for sphinx: https://www.sphinx-doc.org/en/master/usage/extensions/graphviz.html: Would a single .dot file work or we need an html tree?

The .dot file can be embedded using:
.. graphviz:: external.dot

I checked and when running doxygen with graphviz no *.dot files are produced - so I think we might discard this option ....

@malmans2
Copy link
Member

Actually, let me check if there's some kind of extension, because if you just link to the FORTRAN index.html then I doubt all links will work...

@malmans2
Copy link
Member

Nevermind, maybe it just works.
I would try to place the DOMAINcfg html directory under static, then use a link that opens a new tab. For example, use something like this this to define the link

.. |DOMAINcfg_link| raw:: html

   <a href="./_static/DOMAINcfg_html/index.html" target="_blank">NEMO4.0.4-DOMAINcfg tool call tree</a>

then you can show the reference with:

|DOMAINcfg_link|

I guess you could either place the link in our docs/index.rst, or create a separate .rst with a few words about it under docs/developers

oceandie added a commit that referenced this issue May 14, 2021
Add NEMO4 DOMAINcfg tool callgraph #2
@oceandie
Copy link
Contributor

Naive question: why the doc (https://pydomcfg.readthedocs.io/en/latest/) is not updated with my last merged modfications?

@malmans2
Copy link
Member

I can see the call graph. Did you try to force refresh?

domzgr.F90 -> pyDOMCFG automation moved this from In progress to Done Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task do something!
Development

No branches or pull requests

3 participants