New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test configs #17
Test configs #17
Conversation
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 93.12% 93.12%
=======================================
Files 4 4
Lines 160 160
=======================================
Hits 149 149
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…onfigs Adding in @malmans2 suggestions
test_configs ready for merge. |
pre-commit.ci run |
1 similar comment
pre-commit.ci run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# Define sea mount bathymetry | ||
ds["Bathymetry"] = depth * ( | ||
1.0 | ||
- 0.9 | ||
* np.exp( | ||
-( | ||
stiff | ||
/ 40.0e3 ** 2 | ||
* ((ds.glamt - glamt_mid) ** 2 + (ds.gphit - gphit_mid) ** 2) | ||
) | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of hard to read... Maybe define a couple of variables? E.g. ((ds.glamt - glamt_mid) ** 2 + (ds.gphit - gphit_mid) ** 2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok - will fold it in with the DOME PR. It looked fine to me until BLACK reformatted it ;)
pre-commit run --all-files
whats-new.rst