Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement accessor #36

Merged
merged 12 commits into from Jun 19, 2021
Merged

Implement accessor #36

merged 12 commits into from Jun 19, 2021

Conversation

malmans2
Copy link
Member

@malmans2 malmans2 commented Jun 17, 2021

  • Closes Introduce xarray accessor #34
  • Tests added
  • Passes pre-commit run --all-files
  • Changes are documented in whats-new.rst
  • New functions/methods are listed in api.rst
  • Project, label, and assignee tabs are populated

MWE:

import pydomcfg
from pydomcfg.tests.bathymetry import Bathymetry
ds = Bathymetry(1.0e3, 1.2e3, 1, 1).flat(5.0e3)
ds.domcfg.jpk = 31
ds_zco = ds.domcfg.zco(ppdzmin=10, pphmax=5.E3)

@malmans2 malmans2 marked this pull request as draft June 17, 2021 16:42
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #36 (df29e62) into main (6cf13c5) will increase coverage by 0.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   94.05%   94.85%   +0.80%     
==========================================
  Files           4        5       +1     
  Lines         185      214      +29     
==========================================
+ Hits          174      203      +29     
  Misses         11       11              
Flag Coverage Δ
unittests 94.85% <100.00%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydomcfg/domzgr/zco.py 92.38% <ø> (ø)
pydomcfg/__init__.py 75.00% <100.00%> (+3.57%) ⬆️
pydomcfg/accessor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf13c5...df29e62. Read the comment docs.

pydomcfg/accessor.py Outdated Show resolved Hide resolved
pydomcfg/accessor.py Outdated Show resolved Hide resolved
pydomcfg/accessor.py Outdated Show resolved Hide resolved
@malmans2 malmans2 requested a review from a team June 18, 2021 12:06
@malmans2 malmans2 added the enhancement New feature or request label Jun 18, 2021
@malmans2 malmans2 marked this pull request as ready for review June 18, 2021 12:20
@malmans2 malmans2 added this to In progress in domzgr.F90 -> pyDOMCFG via automation Jun 18, 2021
@malmans2
Copy link
Member Author

@pyNEMO/pydomcfg This should be good to go and ready for review.
It just adds the final layer that we expose to users.

domzgr.F90 -> pyDOMCFG automation moved this from In progress to Reviewer approved Jun 19, 2021
@malmans2 malmans2 merged commit 51ee3ad into pyNEMO:main Jun 19, 2021
domzgr.F90 -> pyDOMCFG automation moved this from Reviewer approved to Done Jun 19, 2021
@malmans2 malmans2 deleted the accessor branch June 24, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Introduce xarray accessor
2 participants