Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rdata blog post. #376

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Add rdata blog post. #376

merged 2 commits into from
Apr 18, 2024

Conversation

vnmabus
Copy link
Contributor

@vnmabus vnmabus commented Apr 17, 2024

Adds a blog post highlighting the usage of the recently accepted rdata package.

If you see anything that can/should be improved, please tell me. I was not sure about the metadata (it may be incorrect). Also, English is not my first language, so the text may have errors. Finally, I feel that the image with the pandas is a bit overused and could be changed, but I don't know which image could both be fitting for the topic and visually appealing.

@kierisi
Copy link
Collaborator

kierisi commented Apr 17, 2024

thank you thank you thank you for writing a blog post about your rdata package! as both an R user and the pyOpenSci Community Manager, this makes my heart so happy 💟

I'll leave the review to @lwasser - it looks like there might be some formatting issues, but I'm still learning our setup and don't feel comfortable being the authoritative voice on that.

I'm so excited that you've contributed this post, and I can't wait to share it with the world once it's published! thank you for being such a fantastic part of the pyOpenSci community.

@vnmabus
Copy link
Contributor Author

vnmabus commented Apr 18, 2024

I cannot see the blog in the rendered website. Why is so?

kierisi
kierisi previously approved these changes Apr 18, 2024
Copy link
Collaborator

@kierisi kierisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! We're going to go ahead and merge the post. There's an image that's not rendering right now, but that's because the post doesn't exist online yet.

@kierisi
Copy link
Collaborator

kierisi commented Apr 18, 2024

pre-commit.ci autofix

@kierisi kierisi merged commit efa17b5 into pyOpenSci:main Apr 18, 2024
3 of 4 checks passed
@lwasser
Copy link
Member

lwasser commented Apr 18, 2024

@vnmabus thank you for this blog post pr!! As @kierisi mentioned, we are so appreciative of it!

@vnmabus
Copy link
Contributor Author

vnmabus commented Apr 19, 2024

Wow, that was fast! Thank you for your work!

One thing I have noticed is that you don't seem to use a monospaced font for code, causing some lines to not be aligned (in particular, the dataframe representation does no longer have the column names in their right positions). Apart from that everything seems ok.

@kierisi
Copy link
Collaborator

kierisi commented Apr 19, 2024

that's great feedback! we're in the process of (slowly!) updating our website - would you mind adding the monospaced font for code as an issue so that we don't lose track of it? thanks!

@vnmabus
Copy link
Contributor Author

vnmabus commented Apr 19, 2024

Done.

@vnmabus vnmabus deleted the blogpost/rdata branch April 19, 2024 11:17
@kierisi
Copy link
Collaborator

kierisi commented Apr 19, 2024

thank you!

@kierisi
Copy link
Collaborator

kierisi commented Jun 5, 2024

@all-contibutors add @vnmabus for contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants