Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add movingpandas post #42

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Add movingpandas post #42

merged 2 commits into from
Apr 30, 2020

Conversation

anitagraser
Copy link
Contributor

As promised, here's my blog post on MovingPandas. Please check if I integrated the images correctly since I couldn't find an example in the existing blog posts.

@lwasser
Copy link
Member

lwasser commented Apr 29, 2020

thank you @anitagraser !! i'll have a look at this. we really appreciate your writing it!!

traj.plot()
```

<img src="https://raw.githubusercontent.com/pyOpenSci/pyopensci.github.io/master/images/movingpandas/mpd_fig1.PNG">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this image link will need to be adjusted !

let's do the following.

  1. make the image extension .png (lower case)
  2. image url's should look like this: single sentence text description of image here
    they will then render properly!
  3. this is optional but adding alt tags would be good as it allows people with screen readers to "see" your images via words" a simple text description is plenty.

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes here anita to ensure that the images render properly.

Also it would be super great if you can mention just like pandera did that moving pandas just went through the pyopensci review as well. that's just helpful for context and such! thank you again for submitting this.

@anitagraser
Copy link
Contributor Author

Thank you for checking the draft! I'll get to the pictures asap. One more question:

Also it would be super great if you can mention just like pandera did that moving pandas just went through the pyopensci review as well. that's just helpful for context and such! thank you again for submitting this.

PyOpenSci is currently mentioned in the excerpt (0) and in the second paragraph (1):

(0) "MovingPandas is an easy to use toolkit for exploring movement data that has recently passed the PyOpenSci review."
(1) "MovingPandas has been accepted by pyOpenSci as part of its ecosystem in March 2020. "

What should I add to improve context?

Github didn't pick up on the lower case file extensions. Therefore I had to change the file name.
@lwasser
Copy link
Member

lwasser commented Apr 30, 2020

@anitagraser my apologies. i was trying to work too quickly the other day and missed that piece! all looks great now! the images are rendering locally as well!! i will merge this now. THANK YOU for contributing this to our website!

@lwasser lwasser merged commit ef55a98 into pyOpenSci:master Apr 30, 2020
@ocefpaf ocefpaf mentioned this pull request Apr 18, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants