Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doc_plex #35

Merged
merged 5 commits into from
Feb 16, 2022
Merged

Added doc_plex #35

merged 5 commits into from
Feb 16, 2022

Conversation

toncho11
Copy link
Collaborator

Added dependency docplex and test file.

@toncho11
Copy link
Collaborator Author

It implements #32

@gcattan
Copy link
Collaborator

gcattan commented Feb 14, 2022

Thanks :) I have no further comments.
@qbarthelemy what do you think ?

@qbarthelemy
Copy link
Member

Tests have failed.

tests/test_docplex.py:4:1: E302 expected 2 blank lines, found 1
tests/test_docplex.py:10:12: E714 test for object identity should be 'is not'
tests/test_docplex.py:10:27: W292 no newline at end of file
@toncho11
Copy link
Collaborator Author

Now is OK.

@qbarthelemy qbarthelemy merged commit 0ca711b into pyRiemann:main Feb 16, 2022
@qbarthelemy
Copy link
Member

Thx @toncho11 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants