-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible time steps #191
Flexible time steps #191
Conversation
…he advection field
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 75.67% 75.86% +0.19%
==========================================
Files 123 123
Lines 9273 9450 +177
==========================================
+ Hits 7017 7169 +152
- Misses 2256 2281 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks @dnerini! Yes, I used linear interpolation between the AR time steps, including the perturbation fields in STEPS. Apart from some technical work, I didn't face any major difficulties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pulkkins I went through the code, and I only found very minor suggestions (many of them simply repeat across all nowcasting methods, which explains the number of comments somewhat large…).
I only have one major concern: I included for all nowcast methods (anvil, sseps, steps) an additional test for cases when a list of timesteps is passed (bbd8aeb). My expectation was that the result (in terms of skill) would be equivalent to passing the corresponding number of timesteps (i.e., timesteps=3
vs timesteps=[3]
), but for sseps and steps, this doesn't seem to be the case (the skill is lower, see failed test results). Is this to be expected because of the stochastic nature of the two method?
Good that you raised that concern. I need to do more testing to make sure that the new time step scheme works as intended in all cases. By the way, are you sure that the tests you are referring to are correct? Line 85 of The first index of precip_forecast refers to the ensemble member, not time step. Should that be |
You're absolutely right! This could actually explain the failing tests: with edit: That worked (see 79ac28d)! Nowcasting using |
Thanks for the last changes, @pulkkins , this now looks ready to be merged, well done! |
This pull request aims to address issue #176. The main changes are:
nowcasts
module were constrained to have the same time step with the inputs. Now the user can supply a list of arbitrary output time steps.extrapolation.semilagrangian.extrapolate
withprecip=None
to integrate along the advection field without interpolating the precipitation field.