-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test steps netcdf exporter #202
Conversation
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 76.30% 76.75% +0.45%
==========================================
Files 130 130
Lines 9690 9716 +26
==========================================
+ Hits 7394 7458 +64
+ Misses 2296 2258 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Tests are currently failing for python 3.8 because of an AttributeError in
@aperezhortal do you have any hint on this? |
I was able to reproduce the error in python 3.8. It seems to be originated in the
In case of failure, by default, the Though, I still couldn't find why this error is only raised in python 3.8 and not in 3.6. I'll dig a little bit more into it. |
Nice work! I'll try to take a look at it today. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @dnerini! This tester would find the issue in the future.
Thanks Andres for having a look. Unfortunatly I can't manage to reproduce the error in my 3.8 environment. Can you please share the steps you used? |
These are the steps I followed:
Then, from from the tests directory:
The error seems to related to the new version of scipy (1.6.0) that introduced some improvements to |
Turns out that vel_pert_method='bps' would return all NaNs with a zero motion field (python=3.8)
Thanks @aperezhortal for the help, I was able to reproduce the error by following your steps. This looks a bit complicated and probably deserves a separate issue. For the moment I was able to avoid the error by setting
Worth noticing that with scipy<1.6, step 2 seems to return a field of finite values instead, which doesn't trigger the final AttributeError. I need to look into this a bit more, but it seems that the behavior of |
Closes #200 by including a specific test for the use of a callback function to export a STEPS forecast to netcdf.
Additionally, 42c44d5 fixes a bug introduced by cf34300 which caused an error when a callback was passed with
return_output=True
.