fix: resolve sor bug #413
Open
fix: resolve sor bug #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes pyamg#410 SOR right now fails to include previous x_i values with the relaxation factor. This commit fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #410
Right now, when you run the SOR function, it internally uses a Gauss-Seidel iteration to calculate the next iteration and then incorporates the relaxation factor on the whole matrix. It doesn't include the relaxation factor while calculating the next x_i while in the Gauss-Seidel iteration. This results in incorrect values.
I've tried to resolve this by adding a new function in relaxation.h and adding an extra parameter, omega in the gauss_seidel function which has a default value of 1.0 and calls the sor variant of Gauss-Seidel only if omega is not 1.0
I hope I've followed all the necessary contribution guidelines. Please let me know if I haven't so I can fix it.