fix(task): fix random generators #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, each worker would select the same files, resulting in less randomness than expected.
…nto fix-randomness
…nto fix-randomness
FrenchKrab
added a commit
to FrenchKrab/pyannote-audio
that referenced
this pull request
Jan 24, 2024
But before caching training metadata was introduced Squashed commit of the following: commit d41ce0a Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Thu Jan 11 13:04:18 2024 +0100 doc: fix typo in README commit 8f477fa Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Tue Jan 9 13:06:09 2024 +0100 fix(task): fix random generators (pyannote#1594) Before this change, each worker would select the same files, resulting in less randomness than expected. commit eda0c51 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 17:05:05 2024 +0100 Delete .github/ISSUE_TEMPLATE/feature_request.md commit eb2e813 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 17:04:22 2024 +0100 github: update config.yml (pyannote#1607) commit 27cd91f Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 17:02:40 2024 +0100 github: create config.yml commit 42ef141 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 16:53:52 2024 +0100 github: add bug_report.yml template commit 808b170 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 16:36:24 2024 +0100 feat: add MRE template commit e21e7bb Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 09:52:19 2024 +0100 ci: deactivate FAQtory commit 80634c9 Author: Clément Pagés <55240756+clement-pages@users.noreply.github.com> Date: Fri Dec 22 09:16:12 2023 +0100 fix: update `isort` version to 5.12.0 in pre-commit-config (pyannote#1596) Co-authored-by: clement-pages <clement.pages@irit.fr> commit 7bd88d5 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Wed Dec 20 21:26:42 2023 +0100 feat(pipeline): add Waveform and SampleRate preprocessors (pyannote#1593) commit 4d2d16b Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Wed Dec 20 16:03:13 2023 +0100 doc: update benchmark section (pyannote#1592) commit 66dd72b Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Fri Dec 15 16:10:51 2023 +0100 feat(model): add `num_frames` and `receptive_field` to segmentation models Co-authored-by: Bilal Rahou <Bilal-Rahou@users.noreply.github.com>
FrenchKrab
pushed a commit
to FrenchKrab/pyannote-audio
that referenced
this pull request
Feb 12, 2024
cherry-picked 8f477fa Before this change, each worker would select the same files, resulting in less randomness than expected.
FrenchKrab
added a commit
to FrenchKrab/pyannote-audio
that referenced
this pull request
Feb 12, 2024
Squashed commit. commit 6e22f41 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Thu Feb 8 16:18:10 2024 +0100 improve(pipeline): track all Module instances (not just Model's) (pyannote#1646) commit 8b66bfd Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Thu Feb 8 16:17:32 2024 +0100 fix(util): ensure integer receptive field size (pyannote#1645) commit c3cc56c Author: FrenchKrab <14005967+FrenchKrab@users.noreply.github.com> Date: Thu Feb 8 16:16:46 2024 +0100 fix(task): fix estimation of training set size (pyannote#1644) commit e611d1c Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Sat Feb 3 19:22:27 2024 +0100 feat(model): add `receptive_field` property and `num_frames` method to every model (pyannote#1642) commit e4d850c Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Fri Feb 2 16:52:59 2024 +0100 fix: fix computation of conv1d receptive field (pyannote#1640) commit eba4419 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Thu Feb 1 10:46:37 2024 +0100 improve(metric): add support for number of speakers mismatch in `diarization_error_rate` metric commit fea5c29 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Wed Jan 31 21:55:36 2024 +0100 feat(metric): add `reduce` option to `diarization_error_rate` metric (pyannote#1635) commit d115e9a Author: FrenchKrab <14005967+FrenchKrab@users.noreply.github.com> Date: Tue Jan 30 11:21:08 2024 +0100 feat(powerset): add `Powerset.permutation_mapping` to help with permutation in powerset space Co-authored-by: Hervé BREDIN <hbredin@users.noreply.github.com> commit 9d22113 Author: Clément Pagés <55240756+clement-pages@users.noreply.github.com> Date: Thu Jan 25 17:34:23 2024 +0100 ci: update ci model used for tests commit e431382 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Thu Jan 25 10:42:32 2024 +0100 feat: add pyannote.audio.sample.SAMPLE_FILE (pyannote#1629) commit c0b9e79 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Wed Jan 24 21:47:01 2024 +0100 BREAKING(model): get rid of `Model.example_output` in favor of `num_frames`, `receptive_field`, and `dimension` properties (pyannote#1617) commit 293d8fc Author: FrenchKrab <14005967+FrenchKrab@users.noreply.github.com> Date: Wed Jan 24 11:26:28 2024 +0100 improve: add missing Optional typing commit c921f44 Author: Clément Pagés <55240756+clement-pages@users.noreply.github.com> Date: Mon Jan 15 16:33:27 2024 +0100 fix: remove use of unsigned type (pyannote#1616) commit b41b176 Author: Clément Pagés <55240756+clement-pages@users.noreply.github.com> Date: Mon Jan 15 13:11:21 2024 +0100 fix: fix support for non-ASCII characters Fixes pyannote#1608 pyannote#1612 Co-authored-by: Hervé BREDIN <hbredin@users.noreply.github.com> commit 9e4ec5f Author: Clément Pagés <55240756+clement-pages@users.noreply.github.com> Date: Fri Jan 12 10:46:46 2024 +0100 feat(task): add option to cache training metadata to disk Co-authored-by: Herve Bredin <hbredin@users.noreply.github.com> commit d41ce0a Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Thu Jan 11 13:04:18 2024 +0100 doc: fix typo in README commit 8f477fa Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Tue Jan 9 13:06:09 2024 +0100 fix(task): fix random generators (pyannote#1594) Before this change, each worker would select the same files, resulting in less randomness than expected. commit eda0c51 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 17:05:05 2024 +0100 Delete .github/ISSUE_TEMPLATE/feature_request.md commit eb2e813 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 17:04:22 2024 +0100 github: update config.yml (pyannote#1607) commit 27cd91f Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 17:02:40 2024 +0100 github: create config.yml commit 42ef141 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 16:53:52 2024 +0100 github: add bug_report.yml template commit 808b170 Author: Hervé BREDIN <hbredin@users.noreply.github.com> Date: Mon Jan 8 16:36:24 2024 +0100 feat: add MRE template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each worker in segmentation tasks seem to use the same sequence of files.
This (WIP) PR aims at fixing this.