Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Multilabel Detection #891
[WIP] Multilabel Detection #891
Changes from 37 commits
5fe2153
1d59d44
7ebbc74
14998e6
fd1e3bc
5cc74da
98c97d2
934cf01
ab7112e
1f0c63e
a5947c3
b0ec1a2
a28bacb
e846109
d569f2a
d4584c1
e9df3f8
5f52175
deabd36
ebd12a3
5777043
796926a
5a26f17
fd1acd7
be54c45
6fa3a64
a53519a
828c1d6
21c8df9
a217e99
5198ac7
b515d05
85ba6bc
79c9ff8
3974ded
ef0421b
8d225d2
a51b244
345a262
5fbcb33
4d0c36e
5372c56
897d99f
68e55de
39fff5a
b69cbd1
e49eada
2edf9aa
e7e18db
7dc6296
158e809
551b2c4
4b4f249
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this particular task that may lead to a huge hyperparameter search space, we could also force
onset == offset
(once again through a flaguse_hysteresis
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, let's do that in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't thought a lot about the validation metric for this type of task.
It relies on AUROC right? But what does it mean for multilabel classification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does rely on AUROC I think. I don't have an answer to this. I just used the metric provided by the class without thinking a second about what I was doing. 🙃