Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeakerDiarizationProtocol stats #34

Closed
PaulLerner opened this issue Feb 14, 2020 · 3 comments
Closed

SpeakerDiarizationProtocol stats #34

PaulLerner opened this issue Feb 14, 2020 · 3 comments

Comments

@PaulLerner
Copy link
Contributor

annotation_duration should not consider parts that are not annotated right ?
https://github.com/pyannote/pyannote-database/blob/develop/pyannote/database/protocol/speaker_diarization.py#L194

@hbredin
Copy link
Member

hbredin commented Feb 17, 2020

The current behavior assumes that there is no annotation outside of annotated support.

If there are, this is probably a bug in the provided annotated or annotation values, and it should be fixed upstream.

@PaulLerner
Copy link
Contributor Author

there is no annotation outside of annotated support

Yes but there might be annotation which we don't want to consider as annotation (as in, e.g. our current forced-alignment setup).
However here you take into account the whole annotation duration, regardless of the annotated uem.
You could fix it by adding .crop(annotated) to annotation = item['annotation']

@hbredin
Copy link
Member

hbredin commented Feb 19, 2020

I understand the (your :-)) use case and would be happy to merge a pull request that:

  • crop annotation by annotated
  • warn the user that the crop happened if (and only if) the original annotation was not fully included in annotated
  • update the documentation to reflect this breaking change

PaulLerner pushed a commit to PaulLerner/pyannote-database that referenced this issue Feb 19, 2020
PaulLerner pushed a commit to PaulLerner/pyannote-database that referenced this issue Feb 19, 2020
PaulLerner pushed a commit to PaulLerner/pyannote-database that referenced this issue Feb 21, 2020
PaulLerner pushed a commit to PaulLerner/pyannote-database that referenced this issue Feb 21, 2020
I even got the spaces right this time \o/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants