Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change titles to sentence case #1561

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Conversation

PipKat
Copy link
Member

@PipKat PipKat commented Oct 18, 2022

I also fixed other Google style guide violations that I saw while skimming the file content. Most of these changes were removing future tense and double spaces between sentences. Content reviewed so far includes that in the Getting Started section and half of the User Guide section.

I also fixed other Google style guide violations that I saw while skimming the file content.
@PipKat PipKat requested a review from germa89 October 18, 2022 21:24
@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Oct 18, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1561 (b548890) into main (19173b6) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
- Coverage   82.12%   82.02%   -0.11%     
==========================================
  Files          43       43              
  Lines        6803     6803              
==========================================
- Hits         5587     5580       -7     
- Misses       1216     1223       +7     

PipKat and others added 2 commits October 19, 2022 09:53
Fix typ

Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Btw, it is so obvious I wrote the WSL guide.

@PipKat PipKat merged commit 6535f87 into main Oct 21, 2022
@PipKat PipKat deleted the docs/Change_headings_to_title_case branch October 21, 2022 14:48
@germa89
Copy link
Collaborator

germa89 commented Oct 21, 2022

Btw @PipKat , since it seems you are going to read the whole docs, I would like to remind you that if you see any reference to a method, function or attribute I would like to format them as: :func:`function<ansys.mapdl.core.function>` .

Just ping me to add them, by commenting in the review.

Thank you again!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants