Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick edit of Krylov topic #1593

Merged
merged 12 commits into from
Oct 31, 2022
Merged

Quick edit of Krylov topic #1593

merged 12 commits into from
Oct 31, 2022

Conversation

PipKat
Copy link
Member

@PipKat PipKat commented Oct 27, 2022

I finished my editorial review and attempted to correct issues pointed out by Mechanical APDL writers. Note that this may be the only page that uses Mechanical APDL rather than MAPDL. We might have to do some search and replaces in a separate PR, perhaps after the change to sentence case titles is completed.

@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Oct 27, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #1593 (8e28d7f) into main (ff3a9a8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1593   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files          44       44           
  Lines        7143     7143           
=======================================
  Hits         5915     5915           
  Misses       1228     1228           

@PipKat PipKat requested a review from kmkoshy October 27, 2022 18:03
@PipKat
Copy link
Member Author

PipKat commented Oct 27, 2022

@germa89 Build and Unit Testing (v21.2.1) has been running well over an hour. This doesn't seem normal.

@kmkoshy
Copy link
Contributor

kmkoshy commented Oct 28, 2022

Thanks Kathy for the Review.

Copy link
Contributor

@kmkoshy kmkoshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kathy,
Could you please have a look at a comment I have marked in the doc. This was one of the suggestions that I got and I would like your opinion on this.
Thanks !

doc/source/user_guide/krylov.rst Show resolved Hide resolved
Bumps [plotly](https://github.com/plotly/plotly.py) from 5.10.0 to 5.11.0.
- [Release notes](https://github.com/plotly/plotly.py/releases)
- [Changelog](https://github.com/plotly/plotly.py/blob/master/CHANGELOG.md)
- [Commits](plotly/plotly.py@v5.10.0...v5.11.0)

---
updated-dependencies:
- dependency-name: plotly
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@germa89
Copy link
Collaborator

germa89 commented Oct 28, 2022

@germa89 Build and Unit Testing (v21.2.1) has been running well over an hour. This doesn't seem normal.

Hi @PipKat

It is not! Sometimes that might happen, although it tends to be rare.

The approach then is:

  • Go to the workflow page:

image

  • Cancel workflow (it might take about 5-10 minutes to cancel):
    image

  • and restart workflow:
    image

And now it runs :)

Bumps [ansys-sphinx-theme](https://github.com/ansys/ansys-sphinx-theme) from 0.6.1 to 0.7.0.
- [Release notes](https://github.com/ansys/ansys-sphinx-theme/releases)
- [Commits](ansys/ansys-sphinx-theme@v0.6.1...v0.7.0)

---
updated-dependencies:
- dependency-name: ansys-sphinx-theme
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ansys-dpf-core](https://github.com/pyansys/pydpf-core) from 0.6.1 to 0.6.2.
- [Release notes](https://github.com/pyansys/pydpf-core/releases)
- [Commits](ansys/pydpf-core@v0.6.1...v0.6.2)

---
updated-dependencies:
- dependency-name: ansys-dpf-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.1.3 to 7.2.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@7.1.3...7.2.0)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@PipKat
Copy link
Member Author

PipKat commented Oct 28, 2022

@germa89 Thanks for the instructions on how to handle a test that isn't completing!

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@PipKat PipKat merged commit 09d8436 into main Oct 31, 2022
@PipKat PipKat deleted the doc/edit_krylov_page branch October 31, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants