Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating the requirements #1637

Merged
merged 6 commits into from
Nov 21, 2022

Conversation

clatapie
Copy link
Contributor

Solve #1635

@clatapie clatapie linked an issue Nov 18, 2022 that may be closed by this pull request
3 tasks
@github-actions github-actions bot added Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc) labels Nov 18, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have to update the CI workflows, as requirements files are no longer present in this project.

pyproject.toml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! Next step, adapting the workflow. As @jorgepiloto mentioned there is no longer requirement files so where ever these are mentioned (docs, workflows etc.) it should be readapted.

pyproject.toml Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt really want to do a review, but I pressed shift + enter and here we are... xD

Please ping me when this is ready for review. You can also mark this a draft.

tox.ini Show resolved Hide resolved
@github-actions github-actions bot added the CI/CD Related with CICD, Github Actions, etc label Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #1637 (5c87e72) into main (fb5fb8b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   82.81%   82.81%           
=======================================
  Files          44       44           
  Lines        7151     7151           
=======================================
  Hits         5922     5922           
  Misses       1229     1229           

Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@clatapie clatapie marked this pull request as ready for review November 21, 2022 10:09
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you all! :)

tox.ini Show resolved Hide resolved
@RobPasMue RobPasMue merged commit 22280d3 into main Nov 21, 2022
@RobPasMue RobPasMue deleted the maint/migrate_requirements_to_pyproject_toml branch November 21, 2022 11:12
@germa89
Copy link
Collaborator

germa89 commented Nov 22, 2022

Hi all,

I have stumbled upon this dependency error:

https://github.com/pyansys/pymapdl/actions/runs/3524698134/jobs/5910450776#step:9:61

image

Indeed the version required to install the package is lower than the version required for testing. I wonder then what is the right approach here.

Should I?

  • Downgrade the test version?
  • Upgrade the toml standard version?

To me it makes sense you allow almost any version for the package installation, but then, you test on the latest (current approach until now).
But that now seems to be not an option. Any recommendations on how to approach this dependency error?

@jorgepiloto
Copy link
Member

I am not sure why the second requirement is in conflict with the first one... Even with that, I would encourage to support as many scipy versions as possible, meaning that you should downgrade the test version.

This provides more flexibility when installing old Python versions.

@germa89
Copy link
Collaborator

germa89 commented Nov 22, 2022

Roger that.... But it doesn't make sense....

I'm going to need to change all the common requirements....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate requirements/ to pyproject.toml
4 participants