Migrating the requirements #1637
Conversation
|
Please add one of the following labels to add this contribution to the Release Notes 👇 |
jorgepiloto
left a comment
jorgepiloto
left a comment
There was a problem hiding this comment.
You may have to update the CI workflows, as requirements files are no longer present in this project.
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
It's looking good! Next step, adapting the workflow. As @jorgepiloto mentioned there is no longer requirement files so where ever these are mentioned (docs, workflows etc.) it should be readapted.
germa89
left a comment
germa89
left a comment
There was a problem hiding this comment.
I didnt really want to do a review, but I pressed shift + enter and here we are... xD
Please ping me when this is ready for review. You can also mark this a draft.
…//github.com/pyansys/pymapdl into maint/migrate_requirements_to_pyproject_toml
Codecov Report
@@ Coverage Diff @@
## main #1637 +/- ##
=======================================
Coverage 82.81% 82.81%
=======================================
Files 44 44
Lines 7151 7151
=======================================
Hits 5922 5922
Misses 1229 1229 |
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
germa89
left a comment
germa89
left a comment
There was a problem hiding this comment.
LGTM. Thank you all! :)
|
Hi all, I have stumbled upon this dependency error: https://github.com/pyansys/pymapdl/actions/runs/3524698134/jobs/5910450776#step:9:61
Indeed the version required to install the package is lower than the version required for testing. I wonder then what is the right approach here. Should I?
To me it makes sense you allow almost any version for the package installation, but then, you test on the latest (current approach until now). |
|
I am not sure why the second requirement is in conflict with the first one... Even with that, I would encourage to support as many scipy versions as possible, meaning that you should downgrade the test version. This provides more flexibility when installing old Python versions. |
|
Roger that.... But it doesn't make sense.... I'm going to need to change all the common requirements.... |
Solve #1635