Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving rendering issues for examples documentation #1658

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Nov 29, 2022

As title says. After merging #1649 we realized that there were some issues:

  • Links not properly rendered
  • Missing title

image

This PR will solve those issues

@RobPasMue RobPasMue self-assigned this Nov 29, 2022
@RobPasMue
Copy link
Member Author

We need to merge it before Thursday @germa89 - we are planning on showing this at the PyAnsys API meeting

@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) BUG Issue, problem or error in PyMAPDL labels Nov 29, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1658 (67497de) into main (71d9677) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
+ Coverage   82.74%   82.77%   +0.02%     
==========================================
  Files          44       44              
  Lines        7151     7151              
==========================================
+ Hits         5917     5919       +2     
+ Misses       1234     1232       -2     

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :)

@RobPasMue RobPasMue merged commit c16b6dd into main Nov 29, 2022
@RobPasMue RobPasMue deleted the fix/docs-rendering branch November 29, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants