Skip to content

Conversation

@clatapie
Copy link
Contributor

Closes #1648

@clatapie clatapie self-assigned this Nov 25, 2022
@clatapie clatapie linked an issue Nov 25, 2022 that may be closed by this pull request
3 tasks
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1649 (7d09576) into main (b4c1acf) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
- Coverage   82.84%   82.74%   -0.10%     
==========================================
  Files          44       44              
  Lines        7151     7151              
==========================================
- Hits         5924     5917       -7     
- Misses       1227     1234       +7     

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comments, LGTM!

Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
@RobPasMue RobPasMue marked this pull request as ready for review November 25, 2022 16:34
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@germa89
Copy link
Collaborator

germa89 commented Nov 28, 2022

@clatapie @RobPasMue dont bother about the tests not passing in Windows. That testing is still flaky (I might need to engineer the pytest-rerun extension). So feel free to merge whenever you want.

@clatapie clatapie merged commit 826a820 into main Nov 28, 2022
@clatapie clatapie deleted the maint/deleting_techdemos_from_MAPDL branch November 28, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete techdemos from PyMAPDL repository

4 participants