Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting the VM folder #1722

Merged
merged 17 commits into from
Dec 22, 2022
Merged

Deleting the VM folder #1722

merged 17 commits into from
Dec 22, 2022

Conversation

clatapie
Copy link
Contributor

Closes #1696

@clatapie clatapie self-assigned this Dec 20, 2022
@clatapie clatapie linked an issue Dec 20, 2022 that may be closed by this pull request
Remove the Verification Manual Examples #1696
Closed
2 tasks
@github-actions github-actions bot added Dependencies Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc) labels Dec 20, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Dec 21, 2022 •
edited

Codecov Report

Merging #1722 (711d84f) into main (5e57a31) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1722      +/-   ##
==========================================
+ Coverage   85.26%   85.36%   +0.10%     
==========================================
  Files          45       45              
  Lines        7506     7498       -8     
==========================================
+ Hits         6400     6401       +1     
+ Misses       1106     1097       -9

@clatapie clatapie marked this pull request as ready for review December 22, 2022 09:48
germa89
germa89 reviewed Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

Just two comments:

  • Remember to fix Vale issues
  • Make sure you are not attaching extra files. Like examples/00-mapdl-examples/file.rst or doc/source/examples/gallery_examples/index.rst

doc/source/examples/gallery_examples/index.rst Outdated Show resolved Hide resolved
doc/source/examples/gallery_examples/index.rst Outdated Show resolved Hide resolved
doc/source/examples/gallery_examples/index.rst Outdated Show resolved Hide resolved
doc/source/examples/gallery_examples/index.rst Outdated Show resolved Hide resolved
doc/source/examples/gallery_examples/index.rst Outdated Show resolved Hide resolved
doc/source/examples/gallery_examples/index.rst Outdated Show resolved Hide resolved
doc/source/examples/pymapdl_examples_repo/index.rst Outdated Show resolved Hide resolved
doc/source/examples/pymapdl_examples_repo/index.rst Outdated Show resolved Hide resolved
doc/source/examples/pymapdl_examples_repo/index.rst Outdated Show resolved Hide resolved
doc/source/examples/pymapdl_examples_repo/index.rst Show resolved Hide resolved
clatapie and others added 9 commits December 22, 2022 11:15
@clatapie @germa89
Apply suggestions from code review
2434be2 
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@clatapie @germa89
Update doc/source/examples/gallery_examples/index.rst
d3ed76e 
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@clatapie @germa89
Update doc/source/examples/gallery_examples/index.rst
49f7c19 
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@clatapie @germa89
Update doc/source/examples/gallery_examples/index.rst
89b0433 
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@clatapie @germa89
Update doc/source/examples/gallery_examples/index.rst
021e672 
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@clatapie @germa89
Update doc/source/examples/gallery_examples/index.rst
49a111d 
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@clatapie
Fixing sphinx build
a6c1670
@clatapie
Merge branch 'maint/remove_vm_examples' of https://github.com/ into m…
f2fb94b 
…aint/remove_vm_examples
@germa89
Merge branch 'main' into maint/remove_vm_examples
711d84f
@clatapie clatapie merged commit ac4dfb4 into main Dec 22, 2022
@clatapie clatapie deleted the maint/remove_vm_examples branch December 22, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germa89 germa89 germa89 approved these changes

@RobPasMue RobPasMue Awaiting requested review from RobPasMue

Assignees

@clatapie clatapie

Labels
Dependencies Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the Verification Manual Examples
2 participants
@clatapie @germa89