Deleting the VM folder #1722
Merged
Deleting the VM folder #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
|
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Codecov Report
@@ Coverage Diff @@
## main #1722 +/- ##
==========================================
+ Coverage 85.26% 85.36% +0.10%
==========================================
Files 45 45
Lines 7506 7498 -8
==========================================
+ Hits 6400 6401 +1
+ Misses 1106 1097 -9 |
germa89
reviewed
Dec 22, 2022
Collaborator
germa89
left a comment
germa89
left a comment
There was a problem hiding this comment.
Look good to me.
Just two comments:
- Remember to fix Vale issues
- Make sure you are not attaching extra files. Like
examples/00-mapdl-examples/file.rstordoc/source/examples/gallery_examples/index.rst
germa89
approved these changes
Dec 22, 2022
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
…aint/remove_vm_examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1696