Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding use 'self._path' in '_verify_local' #1780

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 17, 2023

It should fix:

https://github.com/pyansys/pymapdl-examples/actions/runs/3938504282/jobs/6737289359#step:11:109

Let's enforce to use Mapdl.directory instead of Mapdl._path.

@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Jan 17, 2023
@germa89 germa89 requested a review from clatapie January 17, 2023 12:33
@germa89 germa89 self-assigned this Jan 17, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Jan 17, 2023

For some reason, Mapdl.directory returns None. It should not.

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #1780 (b222410) into main (1c70a0a) will increase coverage by 81.64%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           main    #1780       +/-   ##
=========================================
+ Coverage      0   81.64%   +81.64%     
=========================================
  Files         0       45       +45     
  Lines         0     7742     +7742     
=========================================
+ Hits          0     6321     +6321     
- Misses        0     1421     +1421     

@germa89 germa89 merged commit 1200969 into main Jan 17, 2023
@germa89 germa89 deleted the fix/vm-examples-issue branch January 17, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant