Skip to content

Use the gallery to generate the Verification Manual examples #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Feb 6, 2023
Merged

Use the gallery to generate the Verification Manual examples #31

merged 49 commits into from
Feb 6, 2023

Conversation

@clatapie
Copy link
Collaborator

@clatapie clatapie commented Dec 28, 2022 •
edited
Loading

Closes #47.

@clatapie clatapie self-assigned this Dec 28, 2022
@clatapie clatapie linked an issue Dec 28, 2022 that may be closed by this pull request
Automate the creation of the Verification Manual examples #30
Open
@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related labels Dec 28, 2022
@github-actions github-actions bot added the dependencies Related with project dependencies label Dec 29, 2022
@germa89
Copy link
Contributor

germa89 commented Jan 10, 2023

I reaaaaally like the title of this PR.

@akaszynski akaszynski changed the title Automating the creation of the Verification Manual examples Use the gallery to generate the Verification Manual examples Jan 11, 2023
@akaszynski
Copy link

akaszynski commented Jan 11, 2023 •
edited by clatapie
Loading

Pivot this PR to:

@RobPasMue
Copy link
Member

RobPasMue commented Jan 17, 2023

Looks like we hit a bug on PyMAPDL ansys/pymapdl#1780

@clatapie
Copy link
Collaborator Author

clatapie commented Jan 20, 2023

The PyMAPDL bug is still present. This is to be investigated between the PyMAPDL-Examples repository and the PyMAPDL one.

@github-actions github-actions bot added dependencies Related with project dependencies and removed BLOCKER labels Feb 2, 2023
@clatapie clatapie marked this pull request as ready for review February 3, 2023 10:37
@clatapie clatapie requested review from RobPasMue and germa89 February 3, 2023 10:37
@clatapie clatapie removed a link to an issue Feb 3, 2023
Automate the creation of the Verification Manual examples #30
Open
RobPasMue
RobPasMue reviewed Feb 3, 2023
View reviewed changes
RobPasMue
RobPasMue reviewed Feb 3, 2023
View reviewed changes
RobPasMue
RobPasMue approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments only. Glad that this is finally working =)

germa89
germa89 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look very good to me :)

Thank you very much for your nice work @clatapie :)

@RobPasMue
Copy link
Member

RobPasMue commented Feb 3, 2023

Feel free to merge whenever you want @clatapie

@clatapie clatapie merged commit daa2099 into main Feb 6, 2023
@clatapie clatapie deleted the maint/vm_examples branch February 6, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@germa89 germa89 germa89 approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@clatapie clatapie

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use the gallery to generate the Verification Manual examples

5 participants

@clatapie @germa89 @akaszynski @RobPasMue