-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformating command strings in CM related commands #1802
Conversation
Please add one of the following labels to add this contribution to the Release Notes 👇 |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F-strings are so much nicer... 😄 Does this implementation solve the silent crash? Or is it still WIP?
If it is ready for review @clatapie please request it by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @clatapie!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you have formatted some commands, but I dont understand how this is going to fix #1774.
Fundamentally you haven't change anything. Can you clarify what are you trying to do?
From this comment I understand that some of the values returned were not being formatted correctly with the previous approach. Am I wrong? Again... I'm no expert on PyMAPDL. |
I noticed that the file was surprisingly running fine using f-string instead of the previous format. I tried several times and it seemed to work that way. As @RobPasMue explained, I thought it was a formatting issue. |
Sorry I missed the mentioned comment. It is interesting... I did not run the issue. But most of the PyMAPDL commands will only accept strings, hence it should not be needed the You can use the following snippet: https://mapdl.docs.pyansys.com/release/0.64/user_guide/troubleshoot.html#debug-in-pymapdl In the issue script and see what command is sent. If it is a formatting error, you should see it. |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #1802 +/- ##
==========================================
+ Coverage 85.62% 85.84% +0.22%
==========================================
Files 44 44
Lines 7810 7840 +30
==========================================
+ Hits 6687 6730 +43
+ Misses 1123 1110 -13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR does not really address the issue mentioned in #1774. In fact, the user has stopped responding our questions: #1774 (comment)
However, I think the changes proposed are appropriate, hence I'm happy to approve.
I would however delete the test because we are not checking much. But, well.... we can keep it, it does not hurt either. So as you wish.
Closes #1774.