Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow callbacks as strings #18

Merged
merged 3 commits into from
Jul 3, 2022
Merged

feat: allow callbacks as strings #18

merged 3 commits into from
Jul 3, 2022

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jul 3, 2022

        Action(
            id='some.command',
            title="Some Title",
            callback="my_module:some_function",  # resolve at calltime please
        ),

@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #18 (4be3b1c) into main (2924c02) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   99.47%   99.63%   +0.15%     
==========================================
  Files          27       28       +1     
  Lines        1339     1374      +35     
==========================================
+ Hits         1332     1369      +37     
+ Misses          7        5       -2     
Impacted Files Coverage Δ
src/app_model/registries/_commands_reg.py 96.87% <100.00%> (+4.42%) ⬆️
src/app_model/types/_action.py 100.00% <100.00%> (ø)
src/app_model/types/_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2924c02...4be3b1c. Read the comment docs.

@tlambert03 tlambert03 merged commit 51c2f90 into main Jul 3, 2022
@tlambert03 tlambert03 deleted the callable-string branch July 3, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant