Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: raise_synchronous option, and expose app classes #40

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

tlambert03
Copy link
Member

makes it easier for applications to override their registry classes, and also adds a raise_synchronous_exceptions option (defaults to False) that, when True, will raise any exceptions encountered during execute_command in a synchronous context

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #40 (1a67067) into main (b3f1a10) will decrease coverage by 0.10%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   97.53%   97.42%   -0.11%     
==========================================
  Files          31       31              
  Lines        1621     1630       +9     
==========================================
+ Hits         1581     1588       +7     
- Misses         40       42       +2     
Impacted Files Coverage Δ
src/app_model/_app.py 94.91% <83.33%> (-3.20%) ⬇️
src/app_model/registries/_commands_reg.py 94.44% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f1a10...1a67067. Read the comment docs.

@tlambert03 tlambert03 merged commit 1fd7fe4 into pyapp-kit:main Jul 16, 2022
@tlambert03 tlambert03 deleted the expose-classes-and-raise branch July 16, 2022 12:21
@tlambert03 tlambert03 added the enhancement New feature or request label Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

1 participant