Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eval expr when creating menus #61

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

tlambert03
Copy link
Member

this makes it possible to declare an action or menu item with enablement: False (perhaps based on an environment variable or setting or something) to immediately hide it

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #61 (59e8e83) into main (a50fe82) will decrease coverage by 0.11%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   99.46%   99.34%   -0.12%     
==========================================
  Files          31       31              
  Lines        1682     1688       +6     
==========================================
+ Hits         1673     1677       +4     
- Misses          9       11       +2     
Impacted Files Coverage Δ
src/app_model/expressions/_expressions.py 99.02% <75.00%> (-0.98%) ⬇️
src/app_model/backends/qt/_qaction.py 100.00% <100.00%> (ø)
src/app_model/types/_command_rule.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tlambert03 tlambert03 merged commit 9a4f55e into pyapp-kit:main Aug 26, 2022
@tlambert03 tlambert03 deleted the update-expr branch August 26, 2022 12:30
@tlambert03 tlambert03 added the enhancement New feature or request label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

1 participant