Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use eval'd text box as fallback when type inference fails #29

Closed
jni opened this issue Jul 13, 2020 · 1 comment · Fixed by #31
Closed

Use eval'd text box as fallback when type inference fails #29

jni opened this issue Jul 13, 2020 · 1 comment · Fixed by #31
Labels
enhancement New feature or request

Comments

@jni
Copy link
Contributor

jni commented Jul 13, 2020

Many magic typing failures happen for simple arguments (tuple, range, list, (small) dict...) that could actually be easy for users to type in. Rather than fail, magicgui could present a text box that gets eval'd.
@tlambert03 tlambert03 added the enhancement New feature or request label Jul 13, 2020
@jni
Copy link
Contributor Author

jni commented Jul 13, 2020

As @tlambert03 pointed out in Zulip, this should be ast.literal_eval rather than eval.

@tlambert03 tlambert03 mentioned this issue Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add literal eval fallback widget tlambert03/magicgui
2 participants
@jni @tlambert03