add literal eval fallback widget #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
commented
Jul 13, 2020
| @@ -326,14 +326,20 @@ class instance using setattr(self, self.WIDGET_ATTR.format(name), widget). | |||
| try: | |||
| WidgetType = type2widget(arg_type) | |||
| except TypeError: | |||
| funcname = getattr(self.func, "__name__", repr(self.func)) | |||
There was a problem hiding this comment.
not directly related to this PR ... but I found that partial functions weren't working since they don't have a __name__ or __annotation__ attribute.
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 95.76% 95.82% +0.05%
==========================================
Files 13 14 +1
Lines 921 934 +13
==========================================
+ Hits 882 895 +13
Misses 39 39
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29 by adding a
LiteralEvalEditthat is used when type inference fails. As this usesliteral_evalinstead ofeval, this is a "safe" fix, but will miss a lot of edge cases.