Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the entire docstring for the tooltip #108

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Parse the entire docstring for the tooltip #108

merged 3 commits into from
Jan 18, 2021

Conversation

HagaiHargil
Copy link
Contributor

Following #107, I removed the lines that cut off the docstring parsing and fixed the tests. Are there any more places that require an update?

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #108 (f0445ff) into master (45e7a15) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   86.21%   86.19%   -0.03%     
==========================================
  Files          14       14              
  Lines        1763     1760       -3     
==========================================
- Hits         1520     1517       -3     
  Misses        243      243              
Impacted Files Coverage Δ
magicgui/function_gui.py 94.69% <100.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e7a15...20f17c3. Read the comment docs.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good to me

@tlambert03 tlambert03 merged commit 4bb6550 into pyapp-kit:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants