User internal model for Container, simplify ContainerWidgetProtocol
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
changed the title
Container, simply ContainerWidgetProtocolContainer, simplify ContainerWidgetProtocol
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 88.32% 88.34% +0.02%
==========================================
Files 24 24
Lines 2364 2317 -47
==========================================
- Hits 2088 2047 -41
+ Misses 276 270 -6
Continue to review full report at Codecov.
|
jni
reviewed
Jan 21, 2021
| @@ -360,3 +358,25 @@ def f(c): | |||
| assert f.c.choices == (0, 1) | |||
| container.reset_choices() | |||
| assert f.c.choices == (0, 1, 2) | |||
|
|
|||
|
|
|||
| def test_container_indexing_with_native_mucking(): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #111
After thinking about it a bit, I think this is probably the most natural solution to the conundrum I posed in https://github.com/napari/magicgui/issues/111#issuecomment-763624398 (and probably the way it should have been in the first place).
This PR creates an internal list of widgets for
Containers, no longer relying on the backend to be the source of truth. As youappend,insert,pop,removewidgets, the backend only receives commands to add or remove widget instances, (rather than indices), and must find these in their layouts. This actually greatly simplifies the protocol required of the backend widget (at, perhaps, a very slight performance hit when removing items).With this PR, if people start mucking with the native layout, it shouldn't mess up any of public magicgui API. The burden is now on users messing with
native.layout()to deal with any potential indexing issues with their manually added widgets.it also removes the
widget.native_layoutattribute (if you want to get to it, you must usewidget.native.layout()