Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more sizing options (min/max width/height) #116

Merged
merged 5 commits into from
Jan 20, 2021

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jan 20, 2021

Just adding a few more widget-sizing methods to the Protocols. (get/set min/max/current width/height) ... each of width has parallels in ipywidgets

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #116 (5710b6a) into master (770efe6) will decrease coverage by 0.86%.
The diff coverage is 63.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   88.34%   87.47%   -0.87%     
==========================================
  Files          25       25              
  Lines        2369     2452      +83     
==========================================
+ Hits         2093     2145      +52     
- Misses        276      307      +31     
Impacted Files Coverage Δ
magicgui/backends/_qtpy/widgets.py 82.47% <50.00%> (-2.19%) ⬇️
magicgui/widgets/_protocols.py 72.83% <67.74%> (-0.83%) ⬇️
magicgui/widgets/_bases/widget.py 86.90% <70.00%> (-3.68%) ⬇️
magicgui/widgets/_concrete.py 82.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 770efe6...5710b6a. Read the comment docs.

@tlambert03 tlambert03 changed the title Adding more width options Add more sizing options (min/max width/height) Jan 20, 2021
@tlambert03 tlambert03 merged commit eb9e21d into pyapp-kit:master Jan 20, 2021
@tlambert03 tlambert03 deleted the size-protocols branch January 20, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant