Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vertical layout the default #124

Merged
merged 2 commits into from
Jan 23, 2021

Conversation

tlambert03
Copy link
Member

closes #121 by making layout='vertical' the default for magicgui and Containers

@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #124 (9ab4f80) into master (b81fbf4) will increase coverage by 0.20%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   90.33%   90.54%   +0.20%     
==========================================
  Files          25       25              
  Lines        2443     2443              
==========================================
+ Hits         2207     2212       +5     
+ Misses        236      231       -5     
Impacted Files Coverage Δ
magicgui/backends/_qtpy/widgets.py 85.45% <0.00%> (+0.51%) ⬆️
magicgui/widgets/_function_gui.py 96.35% <ø> (ø)
magicgui/widgets/_bases/container_widget.py 93.78% <100.00%> (+0.66%) ⬆️
magicgui/widgets/_bases/widget.py 87.50% <100.00%> (+0.59%) ⬆️
magicgui/widgets/_concrete.py 82.62% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81fbf4...9ab4f80. Read the comment docs.

@tlambert03 tlambert03 merged commit ac5afc9 into pyapp-kit:master Jan 23, 2021
@tlambert03 tlambert03 deleted the vertical-default branch January 23, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make vertical layout default
2 participants