Make _magicgui.pyi stubs
#126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 90.55% 90.51% -0.04%
==========================================
Files 25 25
Lines 2445 2435 -10
==========================================
- Hits 2214 2204 -10
Misses 231 231
Continue to review full report at Codecov.
|
| app: AppRef = None, | ||
| **param_options: dict, | ||
| ) -> Callable[[Callable[..., _R]], MainFunctionGui[_R]]: ... | ||
| @overload # noqa: E302 |
There was a problem hiding this comment.
Why are you squishing this so much?
There was a problem hiding this comment.
that's what black does to pyi files! 😂
There was a problem hiding this comment.
What was the issue?
turns out it was just me being dumb. I was trying to test it interactively in the _magicgui.py file. Now that I have the tests in typesafety I realized they were working even though it didn't seem to be working inside of _magicgui.py ... so I just tried somewhere else and it worked!
There was a problem hiding this comment.
that's what black does to pyi files! 😂
🤢
The type annotations in
_magicgui.pygot a little unsightly in #117. This puts all of the overloads and other typing stuff into_magicgui.pyi. Tests for typing annotations were added (in thetypesafetyfolder) in #117 and are still passing here.