Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve issues with widget visibility #130

Merged
merged 3 commits into from
Jan 24, 2021

Conversation

tlambert03
Copy link
Member

This PR fixes a few bugs around widget visibility, such as an initial disagreement between the widget.visible attribute and the actual visibility of the widget.
It also makes sure that widgets (and their labels) explicitly hidden with widget.hide() are not shown in containers, but can be reshown on demand.

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #130 (03f2364) into master (3d1d3b0) will increase coverage by 0.02%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   90.78%   90.81%   +0.02%     
==========================================
  Files          26       26              
  Lines        2517     2525       +8     
==========================================
+ Hits         2285     2293       +8     
  Misses        232      232              
Impacted Files Coverage Δ
magicgui/widgets/_bases/widget.py 87.28% <94.11%> (-0.22%) ⬇️
magicgui/backends/_qtpy/widgets.py 85.45% <100.00%> (+0.25%) ⬆️
magicgui/widgets/_bases/container_widget.py 93.78% <100.00%> (ø)
magicgui/widgets/_concrete.py 82.28% <100.00%> (+0.13%) ⬆️
magicgui/widgets/_function_gui.py 96.62% <100.00%> (+0.02%) ⬆️
magicgui/widgets/_protocols.py 99.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d1d3b0...03f2364. Read the comment docs.

@tlambert03 tlambert03 merged commit 7f51aef into pyapp-kit:master Jan 24, 2021
@tlambert03 tlambert03 deleted the visibility branch January 24, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant