Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fallback behavior of tqdm iterator inside of *hidden* magicgui widget #131

Merged
merged 3 commits into from
Jan 24, 2021

Conversation

tlambert03
Copy link
Member

This PR allows a tqdm iterator to fallback to the standard console behavior even when inside of an @magicgui decorated function, if the widget is not visible.

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #131 (0f24c6f) into master (7f51aef) will decrease coverage by 0.05%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   90.81%   90.75%   -0.06%     
==========================================
  Files          26       26              
  Lines        2525     2531       +6     
==========================================
+ Hits         2293     2297       +4     
- Misses        232      234       +2     
Impacted Files Coverage Δ
magicgui/widgets/_function_gui.py 96.59% <ø> (-0.03%) ⬇️
magicgui/tqdm.py 94.52% <85.71%> (-2.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f51aef...0f24c6f. Read the comment docs.

@tlambert03 tlambert03 merged commit 0a6961e into pyapp-kit:master Jan 24, 2021
@tlambert03 tlambert03 deleted the tqdm-visibility branch January 24, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant