Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for labels #14

Merged
merged 6 commits into from
May 19, 2020
Merged

Conversation

tlambert03
Copy link
Member

This PR adds labels (using the argument name) by default. Can be turned off with @magicgui(labels=False)... works with both @magicgui(layout='horizontal') and 'vertical'
Screen Shot 2020-05-18 at 2 13 40 PM
Screen Shot 2020-05-18 at 2 13 58 PM

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #14 into master will decrease coverage by 0.08%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   95.71%   95.62%   -0.09%     
==========================================
  Files           4        4              
  Lines         700      732      +32     
==========================================
+ Hits          670      700      +30     
- Misses         30       32       +2     
Impacted Files Coverage Δ
magicgui/_qt.py 96.94% <85.18%> (-1.24%) ⬇️
magicgui/_tests/test_magicgui.py 91.93% <91.66%> (+0.46%) ⬆️
magicgui/core.py 98.79% <92.30%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54559c1...d68c983. Read the comment docs.

@tlambert03 tlambert03 closed this May 19, 2020
@tlambert03 tlambert03 reopened this May 19, 2020
@tlambert03 tlambert03 merged commit 0b0c930 into pyapp-kit:master May 19, 2020
@tlambert03 tlambert03 deleted the labels-forms branch May 19, 2020 00:08
@jni
Copy link
Contributor

jni commented May 19, 2020

😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants