Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move return_annotation from container to FunctionGui #143

Merged
merged 3 commits into from
Feb 10, 2021

Conversation

tlambert03
Copy link
Member

It never really made sense for a Container Widget to have a return annotation. (it was only there for FunctionGui to use). This moves it over to FunctionGui

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #143 (e53babc) into master (aaa4eb9) will decrease coverage by 0.01%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.02%     
==========================================
  Files          25       25              
  Lines        2503     2511       +8     
==========================================
+ Hits         2284     2291       +7     
- Misses        219      220       +1     
Impacted Files Coverage Δ
magicgui/signature.py 94.25% <85.71%> (-0.75%) ⬇️
magicgui/backends/_qtpy/widgets.py 85.78% <100.00%> (+0.03%) ⬆️
magicgui/widgets/_bases/container_widget.py 94.55% <100.00%> (-0.38%) ⬇️
magicgui/widgets/_function_gui.py 96.57% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa4eb9...6126401. Read the comment docs.

@tlambert03 tlambert03 merged commit 52b930e into pyapp-kit:master Feb 10, 2021
@tlambert03 tlambert03 deleted the move-return-annotation branch February 10, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant