Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #148

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Feb 8, 2021

No description provided.

@jni
Copy link
Contributor

jni commented Feb 9, 2021

@tlambert03 here's the failing test on Windows-latest 3.7:

  ================================== FAILURES ===================================
  ______________________________ test_orient_index ______________________________
  
      def test_orient_index():
          """Test to_dict with orient = 'index' ."""
  >       table = Table(value=_TABLE_DATA["dict"])
  
  tests\test_table.py:139: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
  magicgui\widgets\_table.py:224: in __init__
      super().__init__(**kwargs)
  magicgui\widgets\_bases\widget.py:77: in __init__
      self._widget = widget_type(**backend_kwargs)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
  
  self = <magicgui.backends._qtpy.widgets.Table object at 0x000001AC64FF27C8>
  
      def __init__(self):
          super().__init__(QtW.QTableWidget)
  >       self._qwidget.horizontalHeader().setSectionResizeMode(QtW.QHeaderView.Stretch)
  E       AttributeError: 'PySide2.QtWidgets.QTableWidgetItem' object has no attribute 'setSectionResizeMode'
  
  magicgui\backends\_qtpy\widgets.py:578: AttributeError

PySide2 is 5.15.2 which has been out since Nov, so I don't understand why this would fail. Seems unrelated to the PR but I'll let you merge just in case. 😬

@tlambert03
Copy link
Member

That's a weird one; and usually goes away if you rerun it (did you? Cause it seems to be gone now)

No explanation for why rerunning should fix an attribute error!

@jni
Copy link
Contributor

jni commented Feb 9, 2021

That's a weird one; and usually goes away if you rerun it (did you? Cause it seems to be gone now)

How is it gone?

Screen Shot 2021-02-09 at 7 59 03 pm

@jni
Copy link
Contributor

jni commented Feb 9, 2021

(No I did not rerun in case you wanted to Have A Look ™️. 😂)

@tlambert03
Copy link
Member

Gone now! 🤷‍♂️

@jni jni merged commit f2955c3 into master Feb 9, 2021
@jni jni deleted the pre-commit-ci-update-config branch February 9, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants