Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extreme float values for slider and spinbox #178

Merged
merged 7 commits into from
Mar 12, 2021

Conversation

tlambert03
Copy link
Member

fixes #177 as well as a bug when using a FloatSlider with float values greater than 2^32 / 2

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #178 (eba3c9e) into master (c4294a3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   90.05%   90.06%           
=======================================
  Files          29       29           
  Lines        2855     2908   +53     
=======================================
+ Hits         2571     2619   +48     
- Misses        284      289    +5     
Impacted Files Coverage Δ
magicgui/backends/_qtpy/widgets.py 86.95% <100.00%> (+0.15%) ⬆️
magicgui/widgets/_bases/ranged_widget.py 85.56% <100.00%> (+0.95%) ⬆️
magicgui/widgets/_concrete.py 84.22% <100.00%> (+2.25%) ⬆️
magicgui/widgets/_transforms.py 59.52% <0.00%> (-14.29%) ⬇️
magicgui/_util.py 60.60% <0.00%> (-1.52%) ⬇️
magicgui/widgets/_function_gui.py 96.87% <0.00%> (+0.62%) ⬆️
magicgui/type_map.py 91.13% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4294a3...eba3c9e. Read the comment docs.

@tlambert03 tlambert03 requested review from jni and removed request for jni March 12, 2021 00:45
@tlambert03 tlambert03 merged commit dfd4e1b into pyapp-kit:master Mar 12, 2021
@tlambert03 tlambert03 deleted the fix-large-float branch March 12, 2021 13:50
@tlambert03 tlambert03 added the bug Something isn't working label Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

small decimals not working in Qt Backend
1 participant